Re: [PATCH 2/2] fs: Don't open-code lru_to_page

From: David Hildenbrand
Date: Thu Nov 29 2018 - 05:12:19 EST


On 29.11.18 09:18, Michal Hocko wrote:
> On Thu 29-11-18 09:52:57, Nikolay Borisov wrote:
>> There are a bunch of filesystems which essentially open-code lru_to_page
>> helper. Change them to using the helper. No functional changes.
>
> I would just squash the two into a single patch. It makes the first one
> more obvious. Or is there any reason to have them separate?
>
>> Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>
>
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>

mm_inline.h is 99.9% about lru and there is barely anything about lru in
mm.h. However this simple macro seems to differ from the other inlined
functions.

So to the squashed patch

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>


--

Thanks,

David / dhildenb