Re: [PATCH 4.19 033/110] bfs: add sanity check at bfs_fill_super()

From: Greg KH
Date: Thu Nov 29 2018 - 12:10:44 EST


On Thu, Nov 29, 2018 at 04:55:20PM +0000, Tigran Aivazian wrote:
> On Thu, 29 Nov 2018 at 16:07, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Thu, Nov 29, 2018 at 03:23:00PM +0000, Tigran Aivazian wrote:
> > > Yes, of course I object to it.
> > I can not apply a patch to the stable trees that are not in Linus's tree
> > first. So there's nothing I can do here with this.
>
> Ok, we can wait until my patch propagates into Linus' tree, but I
> would have thought it would be a waste of your time to apply a patch
> which is waiting to be inevitably superseded by a different one.

Your patch has to apply on top of the existing one, so there's not an
issue here.

And might as well fix it now, as I can never count on a "future" patch
getting merged.

> I can
> see there are 238 PRs at Linus' tree on github and I am very glad that
> I looked into one of them --- it contained a long comment explaining
> that I should NOT do what I was just about to do, i.e. make a PR
> against Linus' tree! :)

We do not do kernel development on github :)

thanks,

greg k-h