Re: [PATCH v2] module: make it clearer when we're handling kallsyms symbols vs exported symbols

[Jessica Yu]

+++ Miroslav Benes [29/11/18 09:18 +0100]:
> On Fri, 23 Nov 2018, Jessica Yu wrote:
>
> > The module loader internally works with both exported symbols
> > represented as struct kernel_symbol, as well as Elf symbols from a
> > module's symbol table. It's hard to distinguish sometimes which type of
> > symbol we're handling given that some helper function names are not
> > consistent or helpful. Take get_ksymbol() for instance - are we
> > looking for an exported symbol or a kallsyms symbol here? Or symname()
> > and kernel_symbol_name() - which function handles an exported symbol and
> > which one an Elf symbol?
> >
> > Clean up and unify the function naming scheme a bit to make it clear
> > which kind of symbol we're handling. This change only affects static
> > functions internal to the module loader.
> >
> > Signed-off-by: Jessica Yu <jeyu@xxxxxxxxxx>
>
> Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

Applied, thanks!

Jessica