Re: [PATCH 09/14] fs/pstore: Use %pS printk format for direct addresses

From: Kees Cook
Date: Thu Nov 29 2018 - 19:41:13 EST


On Thu, Nov 29, 2018 at 3:49 PM Luck, Tony <tony.luck@xxxxxxxxx> wrote:
>
> On Thu, Nov 29, 2018 at 03:26:51PM -0800, Kees Cook wrote:
> > On Wed, Sep 6, 2017 at 1:28 PM Helge Deller <deller@xxxxxx> wrote:
> > >
> > > Use the %pS instead of the %pF printk format specifier for printing symbols
> > > from direct addresses. This is needed for the ia64, ppc64 and parisc64
> > > architectures.
> > >
> > > Signed-off-by: Helge Deller <deller@xxxxxx>
> > > Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> > > Cc: Tony Luck <tony.luck@xxxxxxxxx>
> >
> > I missed this email from some time ago. I've now applied it, thanks!
>
> Though it isn't really needed any more. See
>
> 04b8eb7a4ccd ("symbol lookup: introduce dereference_symbol_descriptor()")
>
> which is part of the plan to deprecate %pF

Ah-ha! Okay then, nevermind. :) Thanks!

--
Kees Cook