RE: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed

From: Stephen Boyd
Date: Fri Nov 30 2018 - 03:10:23 EST


Quoting Anson Huang (2018-11-29 23:37:14)
> Hi, Stephen
>
> Best Regards!
> Anson Huang
>
> > -----Original Message-----
> > From: Stephen Boyd [mailto:sboyd@xxxxxxxxxx]
> > Sent: 2018å11æ30æ 15:25
> > To: kernel@xxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > linux-clk@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > mturquette@xxxxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx;
> > Anson Huang <anson.huang@xxxxxxx>; Fabio Estevam
> > <fabio.estevam@xxxxxxx>
> > Cc: dl-linux-imx <linux-imx@xxxxxxx>
> > Subject: Re: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed
> >
> > Quoting Anson Huang (2018-11-29 23:23:47)
> > > Same as other i.MX6 SoCs, ensure unused MMDC channel's handshake is
> > > bypassed, this is to make sure no request signal will be generated
> > > when periphe_clk_sel is changed or SRC warm reset is triggered.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> >
> > Does this need a fixes tag?
>
> Normally this bit is 1b'1 by reset, but during our development, it used to be
> overwritten in u-boot and lead to some clock operation fail in Linux kernel, that is why we ensure it
> in clock driver early phase. IMO, it should be OK to not add a fix tag, since it is just
> to make sure the setting is correct and NOT depends on the hardware reset value which
> could be changed in u-boot.
>
>

Hmm ok.