Re: [PATCH 7/9] tools/lib/traceevent: traceevent API cleanup

From: Steven Rostedt
Date: Fri Nov 30 2018 - 14:37:41 EST


On Fri, 30 Nov 2018 16:18:56 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Fri, Nov 30, 2018 at 10:44:10AM -0500, Steven Rostedt escreveu:
> > From: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>
> >
> > In order to make libtraceevent into a proper library, its API
> > should be straightforward. This patch hides few API functions,
> > intended for internal usage only:
> > tep_free_event(), tep_free_format_field(), __tep_data2host2(),
> > __tep_data2host4() and __tep_data2host8().
> > The patch also alignes the libtraceevent summary man page with
> > these API changes.
>
> I applied the previous patches, stopped here as it this one fails with
> the error bellow.

Thanks, I'll take a look at it.

What branch are you applying it against? Just to make sure I'm testing
the same thing you are.

-- Steve

>
> Please resend from this patch onwards.
>
> BTW, this is what I have right now:
>
> [acme@quaco perf]$ git log --oneline - 6
> 9db9efe53c72 (HEAD -> perf/core) tools lib traceevent: Rename tep_free_format() to tep_free_event()
> e58c351e8383 tools lib traceevent, perf tools: Rename 'struct tep_event_format' to 'struct tep_event'
> 4237fd0b60d8 tools lib traceevent: Install trace-seq.h API header file
> bb837f2581dc tools lib traceevent: Added support for pkg-config
> a2c167ad70b6 tools lib traceevent: Implement new API tep_get_ref()
> 51d0337d0198 (acme.korg/perf/core) tools lib traceevent: Add sanity check to is_timestamp_in_us()
>