Re: [PATCH v2 06/15] arm: dts: Add devicetree for OrangePi 2G IoT board

From: Olof Johansson
Date: Mon Dec 03 2018 - 12:53:16 EST


On Mon, Dec 3, 2018 at 9:21 AM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
>
> On Mon, Dec 3, 2018 at 11:11 AM Olof Johansson <olof@xxxxxxxxx> wrote:
> >
> > On Mon, Dec 3, 2018 at 7:54 AM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> > >
> > > On Tue, Nov 20, 2018 at 9:38 PM Manivannan Sadhasivam
> > > <manivannan.sadhasivam@xxxxxxxxxx> wrote:
> > > >
> > > > Add initial devicetree support for OrangePi 2G IoT board from Xunlong.
> > > >
> > > > Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > > > ---
> > > > arch/arm/boot/dts/Makefile | 2 +
> > > > .../boot/dts/rda8810pl-orangepi-2g-iot.dts | 40 +++++++++++++++++++
> > > > 2 files changed, 42 insertions(+)
> > > > create mode 100644 arch/arm/boot/dts/rda8810pl-orangepi-2g-iot.dts
> > > >
> > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > > > index b0e966d625b9..a0fdad8f10dd 100644
> > > > --- a/arch/arm/boot/dts/Makefile
> > > > +++ b/arch/arm/boot/dts/Makefile
> > > > @@ -806,6 +806,8 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> > > > qcom-msm8974-sony-xperia-castor.dtb \
> > > > qcom-msm8974-sony-xperia-honami.dtb \
> > > > qcom-mdm9615-wp8548-mangoh-green.dtb
> > > > +dtb-$(CONFIG_ARCH_RDA) += \
> > > > + rda8810pl-orangepi-2g-iot.dtb
> > > > dtb-$(CONFIG_ARCH_REALVIEW) += \
> > >
> > > Question for Arnd/Olof: can we *please* start putting new SoC families
> > > in sub-dirs?
> >
> > I think we're at a point where it's becoming quite awkward to keep it
> > in a flat directory, yes.
> >
> > Best way to handle this is usually right before the closing of a merge
> > window, so let's do it then. It'll be a conflict-ridden mess if we try
> > to stage something in -next, so I'd rather just do it directly in our
> > tree as a one-shot thing.
>
> While I'd like to see the whole thing converted, I was only asking
> about this one platform. That should be doable now, right?

I'd rather apply this to current scheme and then move everything once,
instead of having maintainers go "Oh, I guess I need to move mine" and
we end up with an onslaught of conflicting pull requests to move
things apart.


-Olof