Re: [PATCH] platform/x86: intel_ips: NULL check before some freeing functions is not needed.

From: Andy Shevchenko
Date: Mon Dec 03 2018 - 14:11:07 EST


On Sun, Dec 2, 2018 at 10:55 PM Thomas Meyer <thomas@xxxxxxxx> wrote:
>
> NULL check before some freeing functions is not needed.

Pushed to my review and testing queue, thanks!

>
> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
> ---
>
> diff -u -p a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1300,8 +1300,7 @@ static const struct file_operations ips_
>
> static void ips_debugfs_cleanup(struct ips_driver *ips)
> {
> - if (ips->debug_root)
> - debugfs_remove_recursive(ips->debug_root);
> + debugfs_remove_recursive(ips->debug_root);
> return;
> }
>


--
With Best Regards,
Andy Shevchenko