[RFC PATCH 12/14] mm/hbind: add migrate command to hbind() ioctl

From: jglisse
Date: Mon Dec 03 2018 - 18:36:40 EST


From: JÃrÃme Glisse <jglisse@xxxxxxxxxx>

This patch add migrate commands to hbind() ioctl, user space can use
this commands to migrate a range of virtual address to list of target
memory.

This does not change the policy for the range, it also ignores any of
the existing policy range, it does not changes the policy for the
range.

Signed-off-by: JÃrÃme Glisse <jglisse@xxxxxxxxxx>
Cc: Rafael J. Wysocki <rafael@xxxxxxxxxx>
Cc: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: Dave Hansen <dave.hansen@xxxxxxxxx>
Cc: Haggai Eran <haggaie@xxxxxxxxxxxx>
Cc: Balbir Singh <balbirs@xxxxxxxxxxx>
Cc: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxx>
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Cc: Felix Kuehling <felix.kuehling@xxxxxxx>
Cc: Philip Yang <Philip.Yang@xxxxxxx>
Cc: Christian KÃnig <christian.koenig@xxxxxxx>
Cc: Paul Blinzer <Paul.Blinzer@xxxxxxx>
Cc: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Cc: John Hubbard <jhubbard@xxxxxxxxxx>
Cc: Ralph Campbell <rcampbell@xxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxxxx>
Cc: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
Cc: Mark Hairgrove <mhairgrove@xxxxxxxxxx>
Cc: Vivek Kini <vkini@xxxxxxxxxx>
Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
Cc: Dave Airlie <airlied@xxxxxxxxxx>
Cc: Ben Skeggs <bskeggs@xxxxxxxxxx>
Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx>
---
include/uapi/linux/hbind.h | 9 ++++++++
mm/hms.c | 43 ++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+)

diff --git a/include/uapi/linux/hbind.h b/include/uapi/linux/hbind.h
index 7bb876954e3f..ededbba22121 100644
--- a/include/uapi/linux/hbind.h
+++ b/include/uapi/linux/hbind.h
@@ -57,6 +57,15 @@ struct hbind_params {
*/
#define HBIND_CMD_BIND 1

+/*
+ * HBIND_CMD_MIGRATE move existing memory to use listed target memory. This is
+ * a best effort.
+ *
+ * Additional dwords:
+ * [0] result ie number of pages that have been migrated.
+ */
+#define HBIND_CMD_MIGRATE 2
+

#define HBIND_IOCTL _IOWR('H', 0x00, struct hbind_params)

diff --git a/mm/hms.c b/mm/hms.c
index 6be6f4acdd49..6764908f47bf 100644
--- a/mm/hms.c
+++ b/mm/hms.c
@@ -368,6 +368,39 @@ static int hbind_bind(struct mm_struct *mm, struct hbind_params *params,
}


+static int hbind_migrate(struct mm_struct *mm, struct hbind_params *params,
+ const uint32_t *targets, uint32_t *atoms)
+{
+ unsigned long size, npages;
+ int ret = -EINVAL;
+ unsigned i;
+
+ size = PAGE_ALIGN(params->end) - (params->start & PAGE_MASK);
+ npages = size >> PAGE_SHIFT;
+
+ for (i = 0; params->ntargets; ++i) {
+ struct hms_target *target;
+
+ target = hms_target_find(targets[i]);
+ if (target == NULL)
+ continue;
+
+ ret = target->hbind->migrate(target, mm, params->start,
+ params->end, params->natoms,
+ atoms);
+ hms_target_put(target);
+
+ if (ret)
+ continue;
+
+ if (atoms[0] >= npages)
+ break;
+ }
+
+ return ret;
+}
+
+
static long hbind_ioctl(struct file *file, unsigned cmd, unsigned long arg)
{
uint32_t *targets, *_dtargets = NULL, _ftargets[HBIND_FIX_ARRAY];
@@ -458,6 +491,16 @@ static long hbind_ioctl(struct file *file, unsigned cmd, unsigned long arg)
if (ret)
goto out_mm;
break;
+ case HBIND_CMD_MIGRATE:
+ if (ndwords != 2) {
+ ret = -EINVAL;
+ goto out_mm;
+ }
+ ret = hbind_migrate(current->mm, &params,
+ targets, atoms);
+ if (ret)
+ goto out_mm;
+ break;
default:
ret = -EINVAL;
goto out_mm;
--
2.17.2