Re: [PATCH] powerpc/mm: dump block address translation on book3s/32

From: Michael Ellerman
Date: Tue Dec 04 2018 - 03:55:39 EST


Christophe LEROY <christophe.leroy@xxxxxx> writes:

> Le 16/11/2018 Ã 11:20, Michael Ellerman a ÃcritÂ:
>> Christophe LEROY <christophe.leroy@xxxxxx> writes:
>>
>>> Le 15/11/2018 Ã 12:46, Michael Ellerman a ÃcritÂ:
>>>> Christophe Leroy <christophe.leroy@xxxxxx> writes:
>>>>
>>>>> This patch adds a debugfs file to dump block address translation:
>>>>>
>>>>> ~# cat /sys/kernel/debug/block_address_translation
>>>>
>>>> My instinct is it should be in /sys/kernel/debug/powerpc. But I guess
>>>> the other page table dump files are not.
>>>
>>> Lol.
>>>
>>> Looks like we have the same instinct ...
>>>
>>> But you rejected my patch https://patchwork.ozlabs.org/patch/750426/ :)
>>
>> Haha. My argument was that the kernel page table dump is not powerpc
>> specific, but this file *is* powerpc specific. Though I guess it's in
>> the same are as the page table / hash table dump, so it may as well live
>> next to them.
>
> I see you took the first version in next-test. It doesn't handle the
> case of 64bits phys addresses. v3 does.
>
> I just sent v4 which does to v3 the changes you did (__init and powerpc/
> subdir)

Thanks, have picked up v4.

cheers