Re: [PATCH] ethernet: fman: fix wrong of_node_put() in probe function

From: David Miller
Date: Tue Dec 04 2018 - 23:43:05 EST


From: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
Date: Mon, 3 Dec 2018 13:21:01 +0100

> After getting a reference to the platform device's of_node the probe
> function ends up calling of_find_matching_node() using the node as an
> argument. The function takes care of decreasing the refcount on it. We
> are then incorrectly decreasing the refcount on that node again.
>
> This patch removes the unwarranted call to of_node_put().
>
> Fixes: 414fd46e7762 ("fsl/fman: Add FMan support")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>

Applied, thank you.