Re: [PATCH 1/3] stackleak: mark stackleak_track_stack() as notrace

From: Steven Rostedt
Date: Wed Dec 05 2018 - 21:26:57 EST


On Wed, 5 Dec 2018 17:08:34 -0800
Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> > diff --git a/kernel/stackleak.c b/kernel/stackleak.c
> > index e42892926244..5de3bf596dd7 100644
> > --- a/kernel/stackleak.c
> > +++ b/kernel/stackleak.c
> > @@ -102,7 +102,7 @@ asmlinkage void stackleak_erase(void)
> > current->lowest_stack = current_top_of_stack() - THREAD_SIZE/64;
> > }
> >
> > -void __used stackleak_track_stack(void)
> > +void __used notrace stackleak_track_stack(void)
> > {
> > /*
> > * N.B. stackleak_erase() fills the kernel stack with the poison value,
> > --
> > 2.19.2
> >
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Steven, I assume this series going via your tree?

??

A notrace addition doesn't make it mine.

I added changes for the cond_resched in a different patch series that
I'll pull in (they are independent from this). I'll Ack the Makefile
change in the tracing directory, but the rest belongs to others.

-- Steve