RE: [LINUX PATCH v12 1/2] dt-bindings: memory: Add pl353 smc controller devicetree binding information

[Naga Sureshkumar Relli]

Hi Michal,

> -----Original Message-----
> From: Michal Simek [mailto:michal.simek@xxxxxxxxxx]
> Sent: Wednesday, December 5, 2018 8:13 PM
> To: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>; mmayer@xxxxxxxxxxxx;
> f.fainelli@xxxxxxxxx; ladis@xxxxxxxxxxxxxx; treding@xxxxxxxxxx; digetx@xxxxxxxxx; d-
> gerlach@xxxxxx
> Cc: linus.walleij@xxxxxxxxxx; Michal Simek <michals@xxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [LINUX PATCH v12 1/2] dt-bindings: memory: Add pl353 smc controller
> devicetree binding information
> 
> On 29. 11. 18 13:57, Naga Sureshkumar Relli wrote:
> > Add pl353 static memory controller devicetree binding information.
> >
> > Signed-off-by: Naga Sureshkumar Relli
> > <naga.sureshkumar.relli@xxxxxxxxxx>
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > ---
> >  .../bindings/memory-controllers/pl353-smc.txt      | 47
> ++++++++++++++++++++++
> >  1 file changed, 47 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> > b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> > new file mode 100644
> > index 0000000..d56615f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.t
> > +++ xt
> > @@ -0,0 +1,47 @@
> > +Device tree bindings for ARM PL353 static memory controller
> > +
> > +PL353 static memory controller supports two kinds of memory
> > +interfaces.i.e NAND and SRAM/NOR interfaces.
> > +The actual devices are instantiated from the child nodes of pl353 smc node.
> > +
> > +Required properties:
> > +- compatible		: Should be "arm,pl353-smc-r2p1", "arm,primecell".
> > +- reg			: Controller registers map and length.
> > +- clock-names		: List of input clock names - "memclk", "apb_pclk"
> > +			  (See clock bindings for details).
> > +- clocks		: Clock phandles (see clock bindings for details).
> > +- address-cells		: Must be 2.
> > +- size-cells		: Must be 1.
> > +
> > +Child nodes:
> > + For NAND the "arm,pl353-nand-r2p1" and for NOR the "cfi-flash"
> > +drivers are supported as child nodes.
> > +
> > +for NAND partition information please refer the below file
> > +Documentation/devicetree/bindings/mtd/partition.txt
> > +
> > +Example:
> > +	smcc: memory-controller@e000e000
> > +			compatible = "arm,pl353-smc-r2p1", "arm,primecell";
> > +			clock-names = "memclk", "apb_pclk";
> > +			clocks = <&clkc 11>, <&clkc 44>;
> > +			reg = <0xe000e000 0x1000>;
> > +			#address-cells = <2>;
> > +			#size-cells = <1>;
> > +			ranges = <0x0 0x0 0xe1000000 0x1000000 //Nand CS Region
> > +				  0x1 0x0 0xe2000000 0x2000000 //SRAM/NOR CS
> Region
> > +				  0x2 0x0 0xe4000000 0x2000000>; //SRAM/NOR CS
> Region
> > +			nand_0: flash@e1000000 {
> > +				compatible = "arm,pl353-nand-r2p1"
> > +				reg = <0 0 0x1000000>;
> > +				(...)
> > +			};
> > +			nor0: flash@e2000000 {
> > +				compatible = "cfi-flash";
> > +				reg = <1 0 0x2000000>;
> > +			};
> > +			nor1: flash@e4000000 {
> > +				compatible = "cfi-flash";
> > +				reg = <2 0 0x2000000>;
> > +			};
> > +	};
> >
> 
> v11 was sent long time ago and also reviewed by Linus here
> https://lore.kernel.org/patchwork/patch/961603/
> 
> I can't see changelog which you have in v11. And also recorded changes if any.
Ok, will add changelog and will send new patch.

Thanks,
Naga Sureshkumar Relli
> Then this driver will go through arm-soc tree via me.
> 
> Thanks,
> Michal