Re: [PATCH 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

From: Vignesh R
Date: Thu Dec 06 2018 - 05:32:06 EST


Hi Roger,

On 05/12/18 8:49 PM, Roger Quadros wrote:
> The AM654 SoC from TI contains a DWC3 controller. Add
> support for it.
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> ---
> Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b/Documentation/devicetree/bindings/usb/keystone-usb.txt
> index f96e09f..fa29ff8 100644
> --- a/Documentation/devicetree/bindings/usb/keystone-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/keystone-usb.txt
> @@ -3,7 +3,7 @@ TI Keystone Soc USB Controller
> DWC3 GLUE
>
> Required properties:
> - - compatible: should be "ti,keystone-dwc3".
> + - compatible: should be "ti,keystone-dwc3" or "ti,am654-dwc3".

Convention is to have one compatible per line:
compatible: Should be
"ti,am654-dwc3" for AM654 SoCs
"ti,keystone-dwc3" for K2 SoCs



> - #address-cells, #size-cells : should be '1' if the device has sub-nodes
> with 'reg' property.
> - reg : Address and length of the register set for the USB subsystem on
> @@ -21,7 +21,7 @@ SoCs only:
> - clock-names: Must be "usb".
>
>
> -The following are mandatory properties for Keystone 2 66AK2G SoCs only:
> +The following are mandatory properties for 66AK2G and AM654:
>
> - power-domains: Should contain a phandle to a PM domain provider node
> and an args specifier containing the USB device id
>

--
Regards
Vignesh