Re: [PATCH] x86/mm/fault: Streamline the fault error_code decoder some more

[Linus Torvalds]

On Thu, Dec 6, 2018 at 11:07 AM Andy Lutomirski <luto@xxxxxxxxxx> wrote:
>
> How do you like the attached patch?

I agree with whoever thought it's odd that "read" is in lower case
when everything else is in upper case.

And honestly, I'd just siggest making the err_text simply have the
real user/kernel difference in it too, using something like

        pr_alert("#PF error: 0x%04lx%s from %s mode\n", error_code, err_txt,
                user_mode(regs) ? "user" : "kernel" );

The "oh, PF_USER and user_mode differs, so let's point that out
explicitly" thing is a good thing regardless.

             Linus