Re: [PATCH] pinctrl: sx150x: handle failure case of devm_kstrdup

From: Linus Walleij
Date: Fri Dec 07 2018 - 07:23:45 EST


On Sun, Dec 2, 2018 at 11:08 AM Nicholas Mc Guire <hofrat@xxxxxxxxx> wrote:

> devm_kstrdup() may return NULL if internal allocation failed.
> Thus using label, name is unsafe without checking. Therefor
> in the unlikely case of allocation failure, sx150x_probe() simply
> returns -ENOMEM.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> Fixes: 9e80f9064e73 ("pinctrl: Add SX150X GPIO Extender Pinctrl Driver")

Patch applied.

> Problem located with an experimental coccinelle script

I like this script.

Yours,
Linus Walleij