Re: [PATCH] x86/vdso: drop implicit common-page-size linker flag

From: Nick Desaulniers
Date: Fri Dec 07 2018 - 13:01:07 EST


On Fri, Dec 7, 2018 at 9:53 AM Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> On Fri, Dec 07, 2018 at 09:45:42AM -0800, Nick Desaulniers wrote:
> > Google's Native Client, a technology for running native code in a web
> > browser. It's since been superseded by Portable Native Client (pNaCl)
> > and to an extent Web Assembly. It seems that BFD still contains code
> > for NaCl.
>
> Yeah, found the wikipedia page. :)
>
> > How does this sound:
> > TL;DR
> > -z common-page-size's default value is based on the target
> > architecture. arch/x86/entry/vdso/Makefile sets it to the
> > architecture default, which is implicit and redundant. Drop it.
>
> Sure. Although the longer explanation gives more insight into the whole
> deal but that's fine too - the longer explanation is on the ML and we
> have the Link: tags.
>
> So no need to resend - I'll simply take the three-liner above.

Thanks, it's being set to the default value again for x86 usermode
linux, arm, and for sparc. I'll send additional clean ups for those
three.
--
Thanks,
~Nick Desaulniers