Re: [PATCH v2 06/19] mailbox: hi3660: Use device-managed registration API

[leo . yan]

On Mon, Dec 17, 2018 at 04:02:04PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> Get rid of some boilerplate driver removal code by using the newly added
> device-managed registration API.

Tested-by: Leo Yan <leo.yan@xxxxxxxxxx>

> Cc: Kevin Wangtao <kevin.wangtao@xxxxxxxxxxxxx>
> Cc: Kaihua Zhong <zhongkaihua@xxxxxxxxxx>
> Cc: Ruyi Wang <wangruyi@xxxxxxxxxx>
> Cc: Leo Yan <leo.yan@xxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
>  drivers/mailbox/hi3660-mailbox.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/drivers/mailbox/hi3660-mailbox.c b/drivers/mailbox/hi3660-mailbox.c
> index f9aed5d8f9f1..53f4bc2488c5 100644
> --- a/drivers/mailbox/hi3660-mailbox.c
> +++ b/drivers/mailbox/hi3660-mailbox.c
> @@ -265,7 +265,7 @@ static int hi3660_mbox_probe(struct platform_device *pdev)
>  	for (ch = 0; ch < MBOX_CHAN_MAX; ch++)
>  		chan[ch].con_priv = (void *)ch;
>  
> -	err = mbox_controller_register(&mbox->controller);
> +	err = devm_mbox_controller_register(dev, &mbox->controller);
>  	if (err) {
>  		dev_err(dev, "Failed to register mailbox %d\n", err);
>  		return err;
> @@ -276,17 +276,8 @@ static int hi3660_mbox_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int hi3660_mbox_remove(struct platform_device *pdev)
> -{
> -	struct hi3660_mbox *mbox = platform_get_drvdata(pdev);
> -
> -	mbox_controller_unregister(&mbox->controller);
> -	return 0;
> -}
> -
>  static struct platform_driver hi3660_mbox_driver = {
>  	.probe  = hi3660_mbox_probe,
> -	.remove = hi3660_mbox_remove,
>  	.driver = {
>  		.name = "hi3660-mbox",
>  		.of_match_table = hi3660_mbox_of_match,
> -- 
> 2.19.1
>