Re: [PATCH] regmap: regmap-irq: Remove default irq type setting from core

From: Matti Vaittinen
Date: Tue Dec 18 2018 - 08:15:08 EST


On Tue, Dec 18, 2018 at 02:08:41PM +0100, Bartosz Golaszewski wrote:
> wt., 18 gru 2018 o 11:58 Matti Vaittinen
> <matti.vaittinen@xxxxxxxxxxxxxxxxx> napisaÅ(a):
> >
> > The common code should not set IRQ type. Read HW defaults to the
> > cache at startup instead of forcing type to EDGE_BOTH. If
> > default setting is needed this should be done via normal
> > mechanisms or by chip specific code if normal mechanisms are not
> > suitable for some reason. Common regmap-irq code should not have
> > defaults hard-coded but keep the HW/boot defaults untouched.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > ---
> > I was not able to test this change as I have no max77620 which seems to
> > be the only user of regmap-irq type-setting in tree as of now.
> >
>
> Works with my work-in-progress max77650 driver that uses the new
> type_in_mask flag.
>
> Tested-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>

Thanks a bunch for testing Bartosz :) Highly appreciated!

--
Matti Vaittinen
ROHM Semiconductors

~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~