Re: [PATCH] Drivers: hv: vmbus: Check for ring when getting debug info

[Sasha Levin]

On Mon, Dec 17, 2018 at 08:16:09PM +0000, Dexuan Cui wrote:
> fc96df16a1ce is good and can already fix the "return stack garbage" issue,
> but let's also improve hv_ringbuffer_get_debuginfo(), which would silently
> return stack garbage, if people forget to check channel->state or
> ring_info->ring_buffer, when using the function in the future.
>
> Having an error check in the function would eliminate the potential risk.
>
> Add a Fixes tag to indicate the patch depdendency.
>
> Fixes: fc96df16a1ce ("Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> Cc: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Signed-off-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> ---
>
> *NOTE*: the patch is based on char-misc's char-misc-linus branch.

Queued up, thank you.

--
Thanks,
Sasha