Re: [PATCH V2] mmc: tegra: HW Command Queue Support for Tegra SDMMC

From: kbuild test robot
Date: Tue Dec 18 2018 - 15:33:27 EST


Hi Sowjanya,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ulf.hansson-mmc/next]
[also build test ERROR on v4.20-rc7 next-20181218]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Sowjanya-Komatineni/mmc-tegra-HW-Command-Queue-Support-for-Tegra-SDMMC/20181218-055358
base: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
config: x86_64-rhel-7.2-clear (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

>> drivers/mmc/host/sdhci-pci-core.c:215:12: error: static declaration of 'sdhci_cqhci_irq' follows non-static declaration
static u32 sdhci_cqhci_irq(struct sdhci_host *host, u32 intmask)
^~~~~~~~~~~~~~~
In file included from drivers/mmc/host/sdhci-pci-core.c:36:0:
drivers/mmc/host/sdhci.h:787:5: note: previous declaration of 'sdhci_cqhci_irq' was here
u32 sdhci_cqhci_irq(struct sdhci_host *host, u32 intmask);
^~~~~~~~~~~~~~~

vim +/sdhci_cqhci_irq +215 drivers/mmc/host/sdhci-pci-core.c

966d696a Adrian Hunter 2017-03-20 214
8ee82bda Adrian Hunter 2017-11-29 @215 static u32 sdhci_cqhci_irq(struct sdhci_host *host, u32 intmask)
8ee82bda Adrian Hunter 2017-11-29 216 {
8ee82bda Adrian Hunter 2017-11-29 217 int cmd_error = 0;
8ee82bda Adrian Hunter 2017-11-29 218 int data_error = 0;
8ee82bda Adrian Hunter 2017-11-29 219
8ee82bda Adrian Hunter 2017-11-29 220 if (!sdhci_cqe_irq(host, intmask, &cmd_error, &data_error))
8ee82bda Adrian Hunter 2017-11-29 221 return intmask;
8ee82bda Adrian Hunter 2017-11-29 222
8ee82bda Adrian Hunter 2017-11-29 223 cqhci_irq(host->mmc, intmask, cmd_error, data_error);
8ee82bda Adrian Hunter 2017-11-29 224
8ee82bda Adrian Hunter 2017-11-29 225 return 0;
8ee82bda Adrian Hunter 2017-11-29 226 }
8ee82bda Adrian Hunter 2017-11-29 227

:::::: The code at line 215 was first introduced by commit
:::::: 8ee82bda230fc972c7ee3bb15ce1260eefb4721c mmc: sdhci-pci: Add CQHCI support for Intel GLK

:::::: TO: Adrian Hunter <adrian.hunter@xxxxxxxxx>
:::::: CC: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip