Re: [PATCH] xen/netfront: tolerate frags with no data

From: Juergen Gross
Date: Wed Dec 19 2018 - 01:03:02 EST


On 19/12/2018 07:00, David Miller wrote:
> From: Juergen Gross <jgross@xxxxxxxx>
> Date: Tue, 18 Dec 2018 16:06:19 +0100
>
>> At least old Xen net backends seem to send frags with no real data
>> sometimes. In case such a fragment happens to occur with the frag limit
>> already reached the frontend will BUG currently even if this situation
>> is easily recoverable.
>>
>> Modify the BUG_ON() condition accordingly.
>>
>> Tested-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
> Applied and queued up for -stable.
>
> But many of these BUG's in the driver should be converted to
> WARNs and recovery code added.
>

Right, but that will be no stable material then. Will start that effort
after Christmas.


Juergen