Re: [PATCH v3] m68k: Fix memblock-related crashes

[Geert Uytterhoeven]

Hi Andreas,

On Mon, Dec 17, 2018 at 8:34 PM Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
> On Dez 17 2018, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
> > On Dez 13 2018, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
> >> I'm now getting this Oops:
> >>
> >> [   65.390000] Unable to handle kernel NULL pointer dereference at virtual address (ptrval)
> >> [   65.390000] Oops: 00000000
> >> [   65.390000] Modules linked in: nls_iso8859_1 nls_cp437 vfat fat virtio_rng virtio_blk virtio_ring virtio xfs btrfs xor zlib_deflate raid6_pq libcrc32c reiserfs squashfs fuse dm_snapshot dm_bufio dm_mod binfmt_misc loop sg
> >> [   65.390000] PC: [<00211544>] blk_throtl_bio+0x10e/0x592
> >
> > And the crash does not occur when I revert commit 1008a11590.
>
> That is not true, so this is an unrelated bug.

Thank you.

So I'll queue my patch as a late fix for v4.20.
Sun-3 can be fixed when someone can test Mike's suggestion.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds