Re: [PATCH 2/3] dt-bindings: gpu: samsung-rotator: Document s5pv210 support

From: Krzysztof Kozlowski
Date: Wed Dec 19 2018 - 11:23:07 EST


On Wed, 19 Dec 2018 at 17:04, PaweÅ Chmiel
<pawel.mikolaj.chmiel@xxxxxxxxx> wrote:
>
> This commit documents new compatible for s5pv210 soc,
> which will be also supported by this driver.
>
> Signed-off-by: PaweÅ Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/gpu/samsung-rotator.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> index 82cd1ed0be93..78658dec6941 100644
> --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> @@ -5,6 +5,7 @@ Required properties:
> (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210
> (b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412
> (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250
> + (d) "samsung,s5pv210-rotator" for Rotator IP in S5PV210

How about putting it at beginning as the oldest chipset? This would
require reordering the list so maybe let's remove the a/b/c list
enumerations? They are kind of useless.

Best regards,
Krzysztof