Re: [PATCH v3] include/linux/nodemask.h: Use nr_node_ids (not MAX_NUMNODES) in __nodemask_pr_numnodes()

From: kbuild test robot
Date: Thu Dec 20 2018 - 19:40:39 EST


Hi Waiman,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.20-rc7 next-20181220]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Waiman-Long/include-linux-nodemask-h-Use-nr_node_ids-not-MAX_NUMNODES-in-__nodemask_pr_numnodes/20181221-082352
config: riscv-tinyconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=riscv

All warnings (new ones prefixed by >>):

In file included from include/linux/sched.h:22,
from arch/riscv/kernel/asm-offsets.c:18:
>> include/linux/nodemask.h:492: warning: "nr_node_ids" redefined
#define nr_node_ids 1

include/linux/nodemask.h:105: note: this is the location of the previous definition
#define nr_node_ids MAX_NUMNODES


vim +/nr_node_ids +492 include/linux/nodemask.h

13808910 Christoph Lameter 2007-10-16 485
13808910 Christoph Lameter 2007-10-16 486 #define for_each_node_state(node, __state) \
13808910 Christoph Lameter 2007-10-16 487 for ( (node) = 0; (node) == 0; (node) = 1)
13808910 Christoph Lameter 2007-10-16 488
8357f869 KAMEZAWA Hiroyuki 2006-03-27 489 #define first_online_node 0
8d060bf4 David Rientjes 2014-08-06 490 #define first_memory_node 0
8357f869 KAMEZAWA Hiroyuki 2006-03-27 491 #define next_online_node(nid) (MAX_NUMNODES)
74c7aa8b Christoph Lameter 2007-02-20 @492 #define nr_node_ids 1
62bc62a8 Christoph Lameter 2009-06-16 493 #define nr_online_nodes 1
13808910 Christoph Lameter 2007-10-16 494

:::::: The code at line 492 was first introduced by commit
:::::: 74c7aa8b8581e0ba8d6d17c623b9279aaabbb0cf [PATCH] Replace highest_possible_node_id() with nr_node_ids

:::::: TO: Christoph Lameter <clameter@xxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip