Re: [PATCH 2/2] ARC: show_regs: fix lockdep splat for good

From: Michal Hocko
Date: Fri Dec 21 2018 - 08:27:58 EST


On Fri 21-12-18 14:04:04, Michal Hocko wrote:
[...]
> Yes, but you are building on a broken concept I believe. What
> implications does re-enabling really have? Now you could reschedule and
> you can move to another CPU. Is this really safe? I believe that yes
> because the preemption disabling is simply bogus. Which doesn't sound
> like a proper justification, does it?

Well, thinking about it a bit more. What is the result of calling
preempt_enable outside of preempt_disabled section? E.g. __warn which
doesn't disable preemption AFAICS.
--
Michal Hocko
SUSE Labs