RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

[Manish Rangankar]

> -----Original Message-----
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
> Sent: Thursday, December 20, 2018 8:46 AM
> To: QLogic-Storage-Upstream@xxxxxxxxxx; jejb@xxxxxxxxxxxxx;
> martin.petersen@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; YueHaibing
> <yuehaibing@xxxxxxxxxx>
> Subject: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
> qla4xxx_copy_from_fwddb_param
> 
> External Email
> 
> ----------------------------------------------------------------------
> External Email
> 
> The return code should be check while qla4xxx_copy_from_fwddb_param fails.
> 
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index
> 949e186..1bc4db6 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct
> scsi_qla_host *ha,
> 
>         rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
>                                            fw_ddb_entry);
> +       if (rc)
> +               goto free_sess;
> 
>         ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
>                    __func__, fnode_sess->dev.kobj.name);
> --
> 2.7.0
> 

Thanks
Acked-by: Manish Rangankar <mrangankar@xxxxxxxxxxx>