Re: [EXT] [PATCH v1] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

From: Ivan Mironov
Date: Mon Dec 24 2018 - 10:16:47 EST


On Mon, 2018-12-24 at 14:26 +0000, Sudarsana Reddy Kalluru wrote:
> Thanks a lot for root-causing the issue and the patch.
> Another (simpler) way to address this would be to invoke bnx2x_del_all_vlans() only for the newer chips, e.g.,
> + if (!CHIP_IS_E1(bp)) {
> /* Remove all currently configured VLANs */
> rc = bnx2x_del_all_vlans(bp);
> if (rc < 0)
> BNX2X_ERR("Failed to delete all VLANs\n");
> + }
> Could you please check on this?

Done. See the PATCH v2 in the mailing list. I tested it on my system.