Re: [PATCH] clk: armada-xp: fix refcount leak in axp_clk_init()

From: Gregory CLEMENT
Date: Wed Dec 26 2018 - 10:45:48 EST


Hi Yangtao,

On mer., dÃc. 26 2018, Yangtao Li <tiny.windzz@xxxxxxxxx> wrote:

> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.

Reviewed-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>

Thanks,

Gregory

>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> ---
> drivers/clk/mvebu/armada-xp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
> index e8f03293ec83..fa1568279c23 100644
> --- a/drivers/clk/mvebu/armada-xp.c
> +++ b/drivers/clk/mvebu/armada-xp.c
> @@ -226,7 +226,9 @@ static void __init axp_clk_init(struct device_node *np)
>
> mvebu_coreclk_setup(np, &axp_coreclks);
>
> - if (cgnp)
> + if (cgnp) {
> mvebu_clk_gating_setup(cgnp, axp_gating_desc);
> + of_node_put(cgnp);
> + }
> }
> CLK_OF_DECLARE(axp_clk, "marvell,armada-xp-core-clock", axp_clk_init);
> --
> 2.17.0
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com