答复: [PATCH 1/1] net-next/hinic:add shutdown callback

[xuechaojing]

HI:

Sorry, I didn't explain this patch clearly.
if there is no shutdown callback, our board will report pcie UNF errors after restarting.
Attached is our log.

Xuechaojing
-----邮件原件-----
发件人: David Miller [mailto:davem@xxxxxxxxxxxxx] 
发送时间: 2018年12月29日 13:49
收件人: xuechaojing <xuechaojing@xxxxxxxxxx>
抄送: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; wulike (A) <wulike1@xxxxxxxxxx>; chiqijun <chiqijun@xxxxxxxxxx>; Wangfengying <fy.wang@xxxxxxxxxx>; Quhuichun (Tony) <tony.qu@xxxxxxxxxx>; Luoshaokai (luoshaokai) <luoshaokai@xxxxxxxxxx>
主题: Re: [PATCH 1/1] net-next/hinic:add shutdown callback

From: Xue Chaojing <xuechaojing@xxxxxxxxxx>
Date: Fri, 28 Dec 2018 00:20:40 +0000

> @@ -1106,6 +1106,13 @@ static void hinic_remove(struct pci_dev *pdev)
>  	dev_info(&pdev->dev, "HiNIC driver - removed\n");  }
>  
> +static void hinic_shutdown(struct pci_dev *pdev) {
> +	pci_disable_device(pdev);
> +
> +	dev_info(&pdev->dev, "HiNIC driver - shutdown\n"); }

I do not think these messages are appropriate.  I didn't catch them before, but I'm not going to let new ones get added.

Attachment: 20180731041827typescript-reboot
Description: 20180731041827typescript-reboot