Re: [PATCH v2] ipv4: fib_rules: Fix possible infinite loop in fib_empty_table

From: David Miller
Date: Sun Dec 30 2018 - 15:57:31 EST


From: YueHaibing <yuehaibing@xxxxxxxxxx>
Date: Sat, 29 Dec 2018 14:45:23 +0800

> gcc warn this:
> net/ipv4/fib_rules.c:203 fib_empty_table() warn:
> always true condition '(id <= 4294967295) => (0-u32max <= u32max)'
>
> 'id' is u32, which always not greater than RT_TABLE_MAX
> (0xFFFFFFFF), So add a check to break while wrap around.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> v2: clean up exit conditions

Applied.