Re: [PATCH] debugfs: debugfs_use_start/finish do not exist anymore

From: Rafael J. Wysocki
Date: Wed Jan 02 2019 - 04:42:10 EST


On Sun, Dec 30, 2018 at 4:49 AM Sergey Senozhatsky
<sergey.senozhatsky@xxxxxxxxx> wrote:
>
> debugfs_use_file_start() and debugfs_use_file_finish() do not exist
> since commit c9afbec27089 ("debugfs: purge obsolete SRCU based removal
> protection"); tweak debugfs_create_file_unsafe() comment.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

> ---
> fs/debugfs/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 13b01351dd1c..4354069101b4 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -422,8 +422,8 @@ EXPORT_SYMBOL_GPL(debugfs_create_file);
> * debugfs core.
> *
> * It is your responsibility to protect your struct file_operation
> - * methods against file removals by means of debugfs_use_file_start()
> - * and debugfs_use_file_finish(). ->open() is still protected by
> + * methods against file removals by means of debugfs_file_get()
> + * and debugfs_file_put(). ->open() is still protected by
> * debugfs though.
> *
> * Any struct file_operations defined by means of
> --
> 2.20.1
>