Re: [PATCH v1 1/2] virtio_pci: use queue idx instead of array idx to set up the vq

From: Cornelia Huck
Date: Thu Jan 03 2019 - 04:57:29 EST


On Fri, 28 Dec 2018 10:26:25 +0800
Wei Wang <wei.w.wang@xxxxxxxxx> wrote:

> When find_vqs, there will be no vq[i] allocation if its corresponding
> names[i] is NULL. For example, the caller may pass in names[i] (i=4)
> with names[2] being NULL because the related feature bit is turned off,
> so technically there are 3 queues on the device, and name[4] should
> correspond to the 3rd queue on the device.
>
> So we use queue_idx as the queue index, which is increased only when the
> queue exists.
>
> Signed-off-by: Wei Wang <wei.w.wang@xxxxxxxxx>
> ---
> drivers/virtio/virtio_pci_common.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>