Re: [PATCH 02/15] swiotlb: remove dma_mark_clean

From: Tony Luck
Date: Thu Jan 03 2019 - 12:35:26 EST


On Wed, Jan 2, 2019 at 11:23 PM Christoph Hellwig <hch@xxxxxx> wrote:
> I think something like the patch below should fix it:
>
> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
> index ccd56f5df8cd..8d7396bd1790 100644
> --- a/arch/ia64/Kconfig
> +++ b/arch/ia64/Kconfig
> @@ -31,7 +31,7 @@ config IA64
> select HAVE_MEMBLOCK_NODE_MAP
> select HAVE_VIRT_CPU_ACCOUNTING
> select ARCH_HAS_DMA_COHERENT_TO_PFN if SWIOTLB
> - select ARCH_HAS_SYNC_DMA_FOR_CPU
> + select ARCH_HAS_SYNC_DMA_FOR_CPU if SWIOTLB

Close. But no cigar. Now I get:

CC arch/ia64/mm/init.o
arch/ia64/mm/init.c:75:6: error: redefinition of âarch_sync_dma_for_cpuâ
./include/linux/dma-noncoherent.h:61:20: note: previous definition of
âarch_sync_dma_for_cpuâ was here
make[1]: *** [arch/ia64/mm/init.o] Error 1
make: *** [arch/ia64/mm/init.o] Error 2


-Tony