Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

From: dann frazier
Date: Thu Jan 03 2019 - 12:41:42 EST


On Wed, Jan 02, 2019 at 08:45:36PM +0800, lipeng (Y) wrote:
>
>
> On 2019/1/1 9:22, dann frazier wrote:
> > On Mon, Nov 26, 2018 at 06:43:00PM +0000, Salil Mehta wrote:
> > > From: Peng Li <lipeng321@xxxxxxxxxx>
> > >
> > > Port 0/1 of HiP08 supports 10G and 25G. This patch adds a
> > > change to configure NIC port speed same as that of optical
> > > module(SFP/QFSP). Driver gets the optical module speed and
> > > sets NIC port speed accordingly.
> > Hi,
> >
> > I'm getting the following errors in dmesg about every 1s on a D06:
> >
> > [ 766.761823] hns3 0000:bd:00.0: get sfp speed failed -5
> > [ 767.785823] hns3 0000:bd:00.0: get sfp speed failed -5
> > [ 768.809820] hns3 0000:bd:00.0: get sfp speed failed -5
> > [ 769.833818] hns3 0000:bd:00.0: get sfp speed failed -5
> >
> > Reverting this patch fixes the issue.
> >
> > -dann
> Hi,dann,
>
> Thanks for your test and report.
>
> This patch needs to match new fireware verison ,
> And it does some work to be Compatible with older versions.

I did upgrade to the latest available firmware (20181213-b20), but the
problem persisted. Maybe the necessary firmware is not yet released?

> Can you show me more informationï
> can you use "ethtool -i ethx" to get the fireware version ,
> and shows me some other message about hns3?

Sure:

$ sudo ethtool -i enp125s0f2
driver: hns3
version: 4.20.0+ SMP mod_unload aarch64
firmware-version: 0xb0311019
expansion-rom-version:
bus-info: 0000:7d:00.2
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: yes
supports-priv-flags: no

-dann