RE: [PATCH 1/2] e1000e: Exclude device from suspend direct complete optimization

From: Brown, Aaron F
Date: Fri Jan 04 2019 - 23:04:32 EST


> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Kai-Heng Feng
> Sent: Tuesday, December 11, 2018 12:00 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Kai-Heng Feng
> <kai.heng.feng@xxxxxxxxxxxxx>
> Subject: [PATCH 1/2] e1000e: Exclude device from suspend direct complete
> optimization
>
> e1000e sets different WoL settings in system suspend callback and
> runtime suspend callback.
>
> The suspend direct complete optimization leaves e1000e in runtime
> suspneded state with wrong WoL setting during system suspend.
>
> To fix this, we need to disable suspend direct complete optimization to
> let e1000e always use suspend callback to set correct WoL during system
> suspend.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>