Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit

From: Adrian Hunter
Date: Mon Jan 07 2019 - 08:22:32 EST


On 7/01/19 1:17 PM, Rafael J. Wysocki wrote:
> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@xxxxxxxxxx> wrote:
>>
>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
>> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>>
>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>> Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxx>
>> ---
>> drivers/mmc/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> index e26b8145efb3..1b9401fe94c0 100644
>> --- a/drivers/mmc/host/Kconfig
>> +++ b/drivers/mmc/host/Kconfig
>> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>>
>> config MMC_SDHCI_ACPI
>> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
>> - depends on MMC_SDHCI && ACPI
>> + depends on MMC_SDHCI && ACPI && PCI
>> select IOSF_MBI if X86
>> help
>> This selects support for ACPI enumerated SDHCI controllers,
>> --
>
> Any objections against this one from anyone?

+ QCOM and AMD contributors