Re: [PATCH v5 02/15] KVM: s390: coding style issue kvm_s390_gisa_init/clear()

[Michael Mueller]

On 02.01.19 17:50, Pierre Morel wrote:
> On 19/12/2018 20:17, Michael Mueller wrote:
> > The change hepls to reduce line length and
> > icreases code readability.
> >
> > Signed-off-by: Michael Mueller <mimu@xxxxxxxxxxxxx>
> > ---
> > Â arch/s390/kvm/interrupt.c | 20 ++++++++++----------
> > Â 1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> > index fcb55b02990e..9a3aed608914 100644
> > --- a/arch/s390/kvm/interrupt.c
> > +++ b/arch/s390/kvm/interrupt.c
> > @@ -2886,20 +2886,20 @@ int kvm_s390_get_irq_state(struct kvm_vcpu 
> > *vcpu, __u8 __user *buf, int len)
> > Â void kvm_s390_gisa_clear(struct kvm *kvm)
> > Â {
> > -ÂÂÂ if (kvm->arch.gisa) {
> > -ÂÂÂÂÂÂÂ memset(kvm->arch.gisa, 0, sizeof(struct kvm_s390_gisa));
> > -ÂÂÂÂÂÂÂ kvm->arch.gisa->next_alert = (u32)(u64)kvm->arch.gisa;
> > -ÂÂÂÂÂÂÂ VM_EVENT(kvm, 3, "gisa 0x%pK cleared", kvm->arch.gisa);
> > -ÂÂÂ }
> > +ÂÂÂ if (!kvm->arch.gisa)
> > +ÂÂÂÂÂÂÂ return;
> > +ÂÂÂ memset(kvm->arch.gisa, 0, sizeof(struct kvm_s390_gisa));
> > +ÂÂÂ kvm->arch.gisa->next_alert = (u32)(u64)kvm->arch.gisa;
> > +ÂÂÂ VM_EVENT(kvm, 3, "gisa 0x%pK cleared", kvm->arch.gisa);
> > Â }
> > Â void kvm_s390_gisa_init(struct kvm *kvm)
> > Â {
> > -ÂÂÂ if (css_general_characteristics.aiv) {
> > -ÂÂÂÂÂÂÂ kvm->arch.gisa = &kvm->arch.sie_page2->gisa;
> > -ÂÂÂÂÂÂÂ VM_EVENT(kvm, 3, "gisa 0x%pK initialized", kvm->arch.gisa);
> > -ÂÂÂÂÂÂÂ kvm_s390_gisa_clear(kvm);
> > -ÂÂÂ }
> > +ÂÂÂ if (!css_general_characteristics.aiv)
> > +ÂÂÂÂÂÂÂ return;
> > +ÂÂÂ kvm->arch.gisa = &kvm->arch.sie_page2->gisa;
> > +ÂÂÂ VM_EVENT(kvm, 3, "gisa 0x%pK initialized", kvm->arch.gisa);
>
> to be annoying, shouldn't the trace be done after the clear?

sure, I will address that

> > +ÂÂÂ kvm_s390_gisa_clear(kvm);
> > Â }
> > Â void kvm_s390_gisa_destroy(struct kvm *kvm)
>
> Reviewed-by: Pierre Morel<pmorel@xxxxxxxxxxxxx>

--