Re: [PATCH v5 08/15] KVM: s390: add the GIB and its related life-cyle functions

[Michael Mueller]

On 03.01.19 10:49, Pierre Morel wrote:
> On 19/12/2018 20:17, Michael Mueller wrote:
> > The Guest Information Block (GIB) links the GISA of all guests
> > that have adapter interrupts pending. These interrupts cannot be
> > delivered because no vcpu of these guests is currently running in
> > SIE context. Instead, a GIB alert is issued on the host to schedule
> > these guests to run.
>
> IMHO "Instead" is not exact.
> The GIB alert is always issued on adapter interrupt if IAM is set even 
> if the guest is running in SIE context.
>
> I would prefer to rephrase to something like:
> "If enabled, a GIB alert is issued on the host..." ?

I agree.

> Reviewed-by: Pierre Morel<pmorel@xxxxxxxxxxxxx>
>
>
> > This mechanism allows to process adapter interrupts for currently
> > not running guests.
> >
> > The GIB is created during host initialization and associated with
> > the Adapter Interruption Facility in case an Adapter Interruption
> > Virtualization Facility is available.
> >
> > The GIB initialization and thus the activation of the related code
> > will be done in an upcoming patch of this series.
> >
> > Signed-off-by: Michael Mueller <mimu@xxxxxxxxxxxxx>
> > Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> > Reviewed-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> > ---
> > Â arch/s390/include/asm/kvm_host.h | 10 +++++++++