[PATCH 1/2] driver: uio: fix possible memory leak in __uio_register_device

From: Liu Jian
Date: Mon Jan 07 2019 - 22:01:23 EST


From: liujian <liujian56@xxxxxxxxxx>

'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.

Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are open")
Signed-off-by: Liu Jian <liujian56@xxxxxxxxxx>
Reviewed-by: Hamish Martin <hamish.martin@xxxxxxxxxxxxxxxxxxx>
---
drivers/uio/uio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 1313422..7280552 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -940,8 +940,10 @@ int __uio_register_device(struct module *owner,
atomic_set(&idev->event, 0);

ret = uio_get_minor(idev);
- if (ret)
+ if (ret) {
+ kfree(idev);
return ret;
+ }

idev->dev.devt = MKDEV(uio_major, idev->minor);
idev->dev.class = &uio_class;
--
2.7.4