Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

From: Herbert Xu
Date: Tue Jan 08 2019 - 00:04:37 EST


On Mon, Jan 07, 2019 at 04:52:00PM +0100, Stephan Mueller wrote:
>
> Would it make sense to polish these mentioned KDF patches and add them to the
> kernel crypto API? The sprawl of key derivation logic here and there which
> seemingly does not comply to any standard and thus possibly have issues should
> be prevented and cleaned up.

Are we going to have multiple implementations for the same KDF?
If not then the crypto API is not a good fit. To consolidate
multiple implementations of the same KDF, simply provide helpers
for them.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt