Re: [PATCH v4 1/2] kobject: use pr_warn to replace printk

[Rafael J. Wysocki]

On Tue, Jan 8, 2019 at 4:11 AM Bo YU <tsu.yubo@xxxxxxxxx> wrote:
>
> This is a fix to replace printk with pr_warn

You call it a "fix", but what exactly is wrong with the code as is?

> Signed-off-by: Bo YU <tsu.yubo@xxxxxxxxx>
> ---
>  lib/kobject_uevent.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
> index 27c6118afd1c..499dfcdafcb0 100644
> --- a/lib/kobject_uevent.c
> +++ b/lib/kobject_uevent.c
> @@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
>  out:
>         if (r) {
>                 devpath = kobject_get_path(kobj, GFP_KERNEL);
> -               printk(KERN_WARNING "synth uevent: %s: %s",
> +               pr_warn("synth uevent: %s: %s",
>                        devpath ?: "unknown device",
>                        msg ?: "failed to send uevent");
>                 kfree(devpath);
> --
> 2.11.0
>