Re: [PATCH] m68k: Avoid VLA use in mangle_kernel_stack()

From: Arnd Bergmann
Date: Tue Jan 08 2019 - 08:36:46 EST


On Mon, Jan 7, 2019 at 10:29 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> With gcc 7.3.0:
>
> arch/m68k/kernel/signal.c: In function âmangle_kernel_stackâ:
> arch/m68k/kernel/signal.c:654:3: warning: ISO C90 forbids variable length array âbufâ [-Wvla]
> unsigned long buf[fsize / 2]; /* yes, twice as much */
> ^~~~~~~~
>
> Replace the variable size by the upper limit, which is 168 bytes.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

I also have a couple of build warning fixes for m68k that I might
post in the next few days, for stuff that I ran into while testing my
y2038 series.

Arnd