Re: [PATCH] arch: unexport asm/shmparam.h for all architectures

From: Stafford Horne
Date: Tue Jan 08 2019 - 17:19:37 EST


On Wed, Jan 09, 2019 at 12:32:28AM +0900, Masahiro Yamada wrote:
> Hi Stafford,
>
>
>
> On Tue, Jan 8, 2019 at 8:12 PM Stafford Horne <shorne@xxxxxxxxx> wrote:
> >
> > What is this patch based on? I tried to apply it to 5.0-rc1 and am having an
> > issue with applying the arch/openrisc/include/uapi/asm/Kbuild part.
>
>
> Based on Linus' latest tree.
> (commit 3bd6e94be)
>
> v5.0-rc1 is NOT the latest.

OK, understood, in that case:

Acked-by: Stafford Horne <shorne@xxxxxxxxx>

(though I see its already being picked up on the -mm tree)

> > It seems shmparam.h is not there. It was removed with the others in your
> > ("d6e4b3e326d8") arch: remove redundant UAPI generic-y defines, commit a few
> > days ago.
> >
> > Note, I can't compile 5.0-rc1 without the first part of this patch. So please
> > get it merged asap :)
>
>
> I notice the breakage of several arches after v5.0-rc1 release,
> so I asked Linus to pick up 3d6e94be.
>
> I had already noticed
> having shmparam.h in uapi is werid,
> but I decided to fix the build errors first.

Yes, that makes sense.

-Stafford