Re: [PATCH v2 3/3] drivers: platform: goldfish: goldfish_sync: add a driver

From: Roman Kiryanov
Date: Tue Jan 08 2019 - 19:48:18 EST


> You have a number of WARN_ON() calls in here that are not needed, please
> remove.

Thank you for noticing, I will remove them.

> Also, why is this driver needed at all? Why can't you use the "normal"
> drm sync api interface? Why write a custom ioctl driver just for this
> one kernel interface?

This driver allows us to talk to host's sync api.