Re: [PATCH v2] arm64: dts: meson: Fix mmc cd-gpio polarity

[Loys Ollivier]

Hi,

On Wed 09 Jan 2019 at 22:14, Martin Blumenstingl wrote:

> Hi,
>
> On Wed, Jan 9, 2019 at 7:31 PM Linus Walleij <linus.walleij@xxxxxxxxxx> 
> wrote:
> > Hi Ollivier!
> >
> > On Wed, Jan 9, 2019 at 2:56 PM Loys Ollivier <lollivier@xxxxxxxxxxxx> 
> > wrote:
> >
> > > Commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> > > changed the behavior of "cd-inverted" to follow the device tree bindings
> > > specification.
> > > Lines specifying "cd-inverted" are now "acitve high".
> there's a typo in the description - it should be "active"
Thanks I'll fix it.
> > >
> > > Fix the SD card for meson by setting the cd-gpio as "active low" 
> > > according
> > > to the boards specifications.
> > >
> > > Fixes: 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> > > Signed-off-by: Loys Ollivier <lollivier@xxxxxxxxxxxx>
> > >
> > > v2: fix more occurences, also in other meson boards.
> >
> > This is a good change in itself since it gets rid of some occasions
> > of the dreaded "cd-inverted" property. I think Martin Blumenstingl
> > already sent patches like these though (I might be confused).
> I sent patches for the 32-bit Amlogic SoCs
> my TODO-list is now a bit longer, I'll test this series on my Khadas
> VIM, VIM2 and Libretech CC during the weekend
I have seen Martin's patch for the arm boards.
This adresses arm64 boards.
Tested on libretech-cc.

> > But we should keep the old device trees working as well.
> > Can you test if Martins patch:
> > https://marc.info/?l=linux-mmc&m=154637189021211&w=2
> >
> > Also makes your boards work?
> feedback on that patch is appreciated
Answered to the patch mail directly. Tested on libretech-cc, it works.
Fixing the meson boards DT for future release would still be valid imho.

> Regards
> Martin

Best,
Loys
--
-L