Re: [PATCH v2] PM/runtime: Fix autosuspend_delay on 32bits arch

From: Tony Lindgren
Date: Thu Jan 10 2019 - 11:44:39 EST


* Vincent Guittot <vincent.guittot@xxxxxxxxxx> [190110 09:00]:
> Cast autosuspend_delay in u64 to make sure that the full computation of
> expires or slack will be done in u64, even on 32bits arch.
> Otherwise, any delay greater than 2^31 nsec can overflow if signed 32bits
> is used when moving delay from msec to nsec
>
> Fixes: 8234f6734c5d ("PM-runtime: Switch autosuspend over to using hrtimers")
> Reported-by: Tony Lindgren <tony@xxxxxxxxxxx>
> Tested-by: Tony Lindgren <tony@xxxxxxxxxxx>
> Signed-off-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> ---
>
> Change since v1:
> - add u64 cast for slack computation

Still works for me.

Thanks,

Tony