Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

From: Joerg Roedel
Date: Fri Jan 11 2019 - 05:23:34 EST



Hi Geert,

On Thu, Dec 20, 2018 at 04:42:17PM +0100, Geert Uytterhoeven wrote:
> > - return ops->add_device(dev);
> > + if (ops)
>
> Is this sufficient? The old code checked for ops->add_device != NULL,
> too.

Robin brought up that all iommu-ops implementations support the
add_device call-back, so we can remove that check and make the call-back
mandatory for new implementations too.

Regards,

Joerg