Re: [PATCH v6 00/16] locking/lockdep: Add support for dynamic keys

From: Peter Zijlstra
Date: Fri Jan 11 2019 - 07:48:45 EST



Hi Bart,

I spotted this new v6 in my inbox and have rebased to it.

On Wed, Jan 09, 2019 at 01:01:48PM -0800, Bart Van Assche wrote:

> The changes compared to v5 are:
> - Modified zap_class() such that it doesn't try to free a list entry that
> is already being freed.

I however have a question on this; this seems wrong. Once a list entry
is enqueued it should not be reachable anymore. If we can reach an entry
after call_rcu() happened, we've got a problem.

> - Added a patch that fixes an existing bug in add_chain_cache().
> - Improved the code that reports the size needed for lockdep data structures
> further.
> - Rebased and retested this patch series on top of kernel v5.0-rc1.