Re: [PATCH] dt-bindings: clock: Convert fixed-clock binding to json-schema

[Stephen Boyd]

Quoting Rob Herring (2019-01-10 14:19:01)
> Convert the fixed-clock binding to DT schema format using json-schema.
> 

Any pointer to the full schema?

> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> Cc: linux-clk@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
[...]
> diff --git a/Documentation/devicetree/bindings/clock/fixed-clock.yaml b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> new file mode 100644
> index 000000000000..8b5628463b90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fixed-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Binding for simple fixed-rate clock sources.

Why does title have a full stop?

> +
> +maintainers:
> +  - Michael Turquette <mturquette@xxxxxxxxxxxx>
> +  - Stephen Boyd <sboyd@xxxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    const: fixed-clock
> +
> +  "#clock-cells":
> +    const: 0
> +
> +  clock-frequency: true

Why doesn't this need the $ref: /schemas/types.yaml#/... thing?

> +  clock-accuracy:
> +    description: accuracy of clock in ppb (parts per billion).
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +  clock-output-names:
> +    maxItems: 1

Is there a schema for strings?

> +
> +required:
> +  - compatible
> +  - "#clock-cells"
> +  - clock-frequency
> +
> +additionalProperties: false

Does this always have to be specified even if it's false?

> +
> +examples:
> +  - |
> +    clock {
> +      compatible = "fixed-clock";
> +      #clock-cells = <0>;
> +      clock-frequency = <1000000000>;
> +      clock-accuracy = <100>;
> +    };
> +...
> 

Is the triple dot part of the schema?